lkml.org 
[lkml]   [2003]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] hugetlbfs: fix error reporting in case of invalid mount options
    On Sat, 7 Jun 2003 09:35:21 -0700 William Lee Irwin III <wli@holomorphy.com> wrote:
    > Let's nuke it entirely. All other fs's barf without printk()'ing at all
    > and kick -EINVAL back to the caller.

    Mmmkay, even better. Patch below.

    René



    diff -u ./fs/hugetlbfs/inode.c~ ./fs/hugetlbfs/inode.c
    --- ./fs/hugetlbfs/inode.c~ 2003-06-07 19:22:27.000000000 +0200
    +++ ./fs/hugetlbfs/inode.c 2003-06-07 19:23:03.000000000 +0200
    @@ -524,10 +524,9 @@
    struct hugetlbfs_config config;

    ret = hugetlbfs_parse_options(data, &config);
    - if (ret) {
    - printk("hugetlbfs: invalid mount options: %s.\n", data);
    + if (ret)
    return ret;
    - }
    +
    sb->s_blocksize = PAGE_CACHE_SIZE;
    sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
    sb->s_magic = HUGETLBFS_MAGIC;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:36    [W:0.021 / U:56.996 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site