lkml.org 
[lkml]   [2003]   [Jun]   [5]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 5 Jun 2003 09:38:15 +0100
FromDave Jones <>
SubjectRe: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70
On Wed, Jun 04, 2003 at 07:14:52PM -0700, Greg KH wrote:

 > > p.s. I'll send these as patches in response to this email to lkml for
 > > those who want to see them.
 > 
 > I don't think everyone really wants to see all 63 different
 > pci_for_each_dev() removal patches

I'm puzzled why you did..

-	pci_for_each_dev(device)
+	while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL)
when you could have just added whatever locking pci_find_device() does
to pci_for_each_dev()  You'd then not have had to touch any of these
drivers, and it'd look a damn sight better to look at IMO.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:36    [from the cache]
©2003-2008