lkml.org 
[lkml]   [2003]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add module_kernel_thread for threads that live in modules.
Neil,

On Thu, Jun 05, 2003 at 12:30:32PM +1000, NeilBrown wrote:

> struct svc_serv *serv = rqstp->rq_server;
> @@ -88,7 +88,6 @@ lockd(struct svc_rqst *rqstp)
> unsigned long grace_period_expire;
>
> /* Lock module and set up kernel thread */
> - MOD_INC_USE_COUNT;
> lock_kernel();
>
> /*
> @@ -181,9 +180,7 @@ lockd(struct svc_rqst *rqstp)
> /* release rpciod */
> rpciod_down();
>
> - /* Release module */
> - unlock_kernel();

You've locked the kernel and didn't unlock it.

> - MOD_DEC_USE_COUNT;
> + return 0;
>

Andrey

--
-------------------------------------------------------------
Andrey Klochko
System Administrator
Sibley School of Mechanical and Aerospace Engineering
288 Grumman Hall
Cornell University
Ithaca, NY 14853
e-mail: andrey@mae.cornell.edu
phone: 607-255-0360
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.123 / U:0.004 seconds]
©2003-2011 Jasper Spaans. Advertise on this site