lkml.org 
[lkml]   [2003]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH] Fix ide-mod unload crash
From
This patch fixes an unload crash when no PCI drivers are loaded.

It's scary that people writing code like this is hacking on the
driver where all my data is stored on! Time to make more backups :)
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: drivers/ide/ide-proc.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/ide/ide-proc.c,v
retrieving revision 1.1.1.6
diff -u -r1.1.1.6 ide-proc.c
--- drivers/ide/ide-proc.c 1 Jun 2003 03:06:25 -0000 1.1.1.6
+++ drivers/ide/ide-proc.c 3 Jun 2003 10:54:58 -0000
@@ -982,16 +982,11 @@
void proc_ide_destroy(void)
{
#ifdef CONFIG_BLK_DEV_IDEPCI
- ide_pci_host_proc_t *p = ide_pci_host_proc_list;
- char name[32];
+ ide_pci_host_proc_t *p;

- while ((p->name != NULL) && (p->set) && (p->get_info != NULL)) {
- name[0] = '\0';
- sprintf(name, "ide/%s", p->name);
+ for (p = ide_pci_host_proc_list; p; p = p->next) {
if (p->set == 2)
remove_proc_entry(p->name, p->parent);
- if (p->next == NULL) break;
- p = p->next;
}
#endif /* CONFIG_BLK_DEV_IDEPCI */
remove_proc_entry("ide/drivers", proc_ide_root);
\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.244 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site