lkml.org 
[lkml]   [2003]   [Jun]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateWed, 04 Jun 2003 14:26:22 -0700
FromMatthew Dobson <>
Subject[patch] use valid value when unmapping cpus
For some unknown reason, we stick a -1 in cpu_2_node when we unmap a cpu 
on i386.  We're better off sticking a 0 in there, because at least 0 is 
a valid value if something references it.  -1 is only going to cause 
problems at some point down the line.  Besides, we initialize the array 
with 0's, so undoing it should return it to that same value.

Cheers!

-Matt
--- linux-2.5.70-vanilla/arch/i386/kernel/smpboot.c	Mon Mar 24 14:00:35 2003
+++ linux-2.5.70-vanilla/arch/i386/kernel/smpboot.c.fixed	Wed Apr  2 18:23:06 2003
@@ -520,7 +520,7 @@
 	printk("Unmapping cpu %d from all nodes\n", cpu);
 	for (node = 0; node < MAX_NR_NODES; node ++)
 		node_2_cpu_mask[node] &= ~(1 << cpu);
-	cpu_2_node[cpu] = -1;
+	cpu_2_node[cpu] = 0;
 }
 #else /* !CONFIG_NUMA */
 
\
 
 \ /
  Last update: 2005-03-22 12:36    [W:1.687 / U:0.220 seconds]
©2003-2008 Jasper Spaans