Messages in this thread | | | Date | Mon, 30 Jun 2003 16:14:26 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 1/4] Optimize NFS open() calls by means of 'intents'... |
| |
On Mon, Jun 30, 2003 at 04:36:45PM +0200, Trond Myklebust wrote: > +++ linux-2.5.73-04-lookupintent/include/linux/namei.h 2003-06-30 08:48:43.000000000 +0200 > struct nameidata { > struct dentry *dentry; > struct vfsmount *mnt; > struct qstr last; > unsigned int flags; > int last_type; > + > + /* Intent data */ > + union { > + struct open_intent open; > + } u; > + > +#if 0 > + /* FS private data */ > + void *it_private; > + void (*it_release)(struct nameidata *, void *); > +#endif
Can we call the union something descriptive (eg "intent") rather than "u"? "u" only makes sense when you're working around not having anonymous unions.
-- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |