lkml.org 
[lkml]   [2003]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Support for mach-xbox (updated)
On Tue, Jun 03, 2003 at 11:11:13AM +0200, Anders Gustafsson wrote:
> Updated according to Sam and Mikaels comments.

you missed one 8-)

> +static void xbox_pic_cmd(u8 command)
> +{
> + outw_p(((XBOX_PIC_ADDRESS) << 1),XBOX_SMB_HOST_ADDRESS);
> + outb_p(SMC_CMD_POWER, XBOX_SMB_HOST_COMMAND);
> + outw_p(command, XBOX_SMB_HOST_DATA);
> + outw_p(inw(XBOX_SMB_IO_BASE),XBOX_SMB_IO_BASE);
> + outb_p(0x0a,XBOX_SMB_GLOBAL_ENABLE);
> +}

Last 4 lines all use spaces instead of tabs.

> targets := vmlinux vmlinux.bin vmlinux.bin.gz head.o misc.o piggy.o
> +ifeq ($(CONFIG_X86_XBOX),y)
> +#XXX Compiling with optimization makes 1.1-xboxen
> +# crash while decompressing the kernel
> +CFLAGS_misc.o := -O0
> +endif

curious. does it matter which version of gcc you used ?
this sounds like a band-aid for something else that needs fixing.

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.046 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site