lkml.org 
[lkml]   [2003]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] 2.[45] eexpress.c skb_padto fixes broke pppoe
From
Date
Hi,

On Sat, 2003-06-21 at 08:46, Alan Cox wrote:
[..SNIP..]
>
> Cleaner is to set buf->len = ETH_ZLEN for the padto path IMHO, that
> keeps the old horrible length compute stuff dead
>

Attached is a better patch that also removes a duplicate comment. I have
tested it on 2.4 but it applies to 2.5 as well (with offset).

Regards,

Shane
--- linux-2.4.21aarc8A/drivers/net/eexpress.c.broken Fri Jun 13 10:51:34 2003
+++ linux-2.4.21aarc8A/drivers/net/eexpress.c Sat Jun 21 18:50:03 2003
@@ -654,7 +654,7 @@
buf = skb_padto(buf, ETH_ZLEN);
if(buf == NULL)
return 0;
- length = buf->len;
+ length = ETH_ZLEN;
}

disable_irq(dev->irq);
@@ -682,13 +682,6 @@
enable_irq(dev->irq);
return 0;
}
-
-/*
- * Handle an EtherExpress interrupt
- * If we've finished initializing, start the RU and CU up.
- * If we've already started, reap tx buffers, handle any received packets,
- * check to make sure we've not become wedged.
- */

/*
* Handle an EtherExpress interrupt
\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.056 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site