Messages in this thread |  | | | Date | Sun, 22 Jun 2003 11:47:01 +0200 (MEST) | | From | Geert Uytterhoeven <> | | Subject | Re: [PATCH] Permit big console scrolls |
| |
On Sun, 22 Jun 2003, Andrew Morton wrote: > Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > - if (get_user(lines, (char *)arg+1)) { > > ^^^^^ > > > + if (get_user(lines, (s32 *)((char *)arg+4))) { > > ^^^^^ > > > ret = -EFAULT; > > > } else { > > > scrollfront(lines); > > > > Why was the `arg+1' changed to `arg+4'? Do we really want to skip 12 bytes? > > It skips three bytes?
Oops, you're right. But my first question remains: why skip 3 bytes?
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |