lkml.org 
[lkml]   [2003]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] udev enhancements to use kernel event queue
    On Fri, Jun 13, 2003 at 10:01:47PM +0200, Oliver Neukum wrote:
    >
    > > +
    > > + spin_lock(&sequence_lock);
    > > + envp [i++] = scratch;
    > > + scratch += sprintf(scratch, "SEQNUM=%ld", sequence_num) + 1;
    > > + ++sequence_num;
    > > + spin_unlock(&sequence_lock);
    > >
    > > kobj_path_length = get_kobj_path_length (kset, kobj);
    > > kobj_path = kmalloc (kobj_path_length, GFP_KERNEL);
    >
    > If this kmalloc fails, you'll have a hole in the numbers and
    > user space will be very confused. You need to report dropped
    > events if you do this.

    Yes, we should add the sequence number last.

    Good catch.

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:36    [W:0.020 / U:63.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site