Messages in this thread | | | Date | Tue, 17 Jun 2003 13:19:27 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] O_DIRECT for ext3 (2.4.21) |
| |
Andrew Morton <akpm@digeo.com> wrote: > > I think the check should be implemented in (the new) ext3_open(). Because > checking the return from open() is the way in which a good application would > determine whether the underlying fs supports O_DIRECT. > > Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to > have forgotten to provide a way for the fs to be told about fcntl.
It works out OK in 2.5, and we should do it this way in 2.4 too:
- dentry_open() checks for inode->i_mapping->a_ops->direct_IO
- setfl() checks for inode->i_mapping->a_ops->direct_IO
- the a_ops for data-journalled inodes have a null ->direct_IO.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |