[lkml]   [2003]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] O_DIRECT for ext3 (2.4.21)
Andrew Morton <> wrote:
> I think the check should be implemented in (the new) ext3_open(). Because
> checking the return from open() is the way in which a good application would
> determine whether the underlying fs supports O_DIRECT.
> Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to
> have forgotten to provide a way for the fs to be told about fcntl.

It works out OK in 2.5, and we should do it this way in 2.4 too:

- dentry_open() checks for inode->i_mapping->a_ops->direct_IO

- setfl() checks for inode->i_mapping->a_ops->direct_IO

- the a_ops for data-journalled inodes have a null ->direct_IO.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:36    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean