lkml.org 
[lkml]   [2003]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] O_DIRECT for ext3 (2.4.21)
Andrew Morton <akpm@digeo.com> wrote:
>
> I think the check should be implemented in (the new) ext3_open(). Because
> checking the return from open() is the way in which a good application would
> determine whether the underlying fs supports O_DIRECT.
>
> Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to
> have forgotten to provide a way for the fs to be told about fcntl.

It works out OK in 2.5, and we should do it this way in 2.4 too:

- dentry_open() checks for inode->i_mapping->a_ops->direct_IO

- setfl() checks for inode->i_mapping->a_ops->direct_IO

- the a_ops for data-journalled inodes have a null ->direct_IO.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.260 / U:0.092 seconds]
©2003-2014 Jasper Spaans. Advertise on this site