Messages in this thread | | | Date | Thu, 12 Jun 2003 08:35:14 -0700 | Subject | Re: 2.5.70-bk16: nfs crash | From | Trond Myklebust <> |
| |
>>>>> " " == Dipankar Sarma <dipankar@in.ibm.com> writes:
> I am not supprised at all by this, I can see two csets in > Linus' tree that will definitely break dcache -
> 1. http://linux.bkbits.net:8080/linux-2.5/cset@1.1215.104.2?nav=index.html|ChangeSet@-2d
> __d_drop() *must not* initialize d_hash fields. Lockfree lookup > depends on that. If __d_drop() needs to be allowed on an > unhashed dentry, the right thing to do would be to check for > DCACHE_UNHASHED before unhashing. I will submit a patch a > little later to do this.
Can you please remind us exactly what the benefits of all this are? Why can't d_free() immediately free the memory instead of relying on the RCU mechanism?
Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |