Messages in this thread |  | | | Date | Wed, 11 Jun 2003 13:53:33 +0100 | | From | Dave Jones <> | | Subject | Re: [PATCH] And yet more PCI fixes for 2.5.70 |
| |
On Wed, Jun 11, 2003 at 01:37:37PM +0100, Alan Cox wrote: > On Mer, 2003-06-11 at 01:11, Greg KH wrote: > > /* user supplied value */ > > system_bus_speed = idebus_parameter; > > - } else if (pci_present()) { > > + } else if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) != NULL) { > > That is just gross. pci_present() is far more readable even if you make > it an inline in pci.h that is pci_find_device(PCI_ANY_ID, PCI_ANY_ID, > NULL)
That was my argument I was trying to get across with the previous lot of ugly PCI changes. I lost that one, and lost the will to fight this one.
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |