lkml.org 
[lkml]   [2003]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] And yet more PCI fixes for 2.5.70
    On Wed, Jun 11, 2003 at 01:37:37PM +0100, Alan Cox wrote:
    > On Mer, 2003-06-11 at 01:11, Greg KH wrote:
    > > /* user supplied value */
    > > system_bus_speed = idebus_parameter;
    > > - } else if (pci_present()) {
    > > + } else if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) != NULL) {
    >
    > That is just gross. pci_present() is far more readable even if you make
    > it an inline in pci.h that is pci_find_device(PCI_ANY_ID, PCI_ANY_ID,
    > NULL)

    The whole surround code seems rather bogus. Most of the drivers actually
    using this are PCI ones so we _know_ pci is present when this gets
    called. And for the few other it should probably be a per-driver
    thing instead, i.e. if the device hangs of a specific pci bus use
    the ide busspeed, else not.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:36    [W:0.020 / U:30.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site