Messages in this thread | | | Date | Wed, 11 Jun 2003 14:54:38 -0700 (PDT) | From | Patrick Mochel <> | Subject | Re: BUG in driver model class.c |
| |
On Wed, 11 Jun 2003, Greg KH wrote:
> On Wed, Jun 11, 2003 at 01:12:47PM -0400, Alan Stern wrote: > > Greg: > > > > There is a bug in drivers/base/class.c in 2.5.70. Near the start of the > > routine class_device_add() are the lines > > > > if (class_dev->dev) > > get_device(class_dev->dev); > > > > But there's nothing to undo this get_device, either in the error return > > part of class_device_add() or in class_device_del(). > > > > I assume that either this get_device() doesn't belong there or else there > > should be corresponding put_device() calls in the other two spots. > > Whichever is the case, it should be easy for you to fix. > > You are correct. I took out the other put_device() in the -bk tree in > class_device_del() but forgot to remove this one. Good catch. > > Pat, here's a patch to fix this up, against the latest -bk tree.
Applied, thanks,
-pat
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |