Messages in this thread | | | Date | Sun, 1 Jun 2003 09:52:52 -0700 | From | Larry McVoy <> | Subject | Re: Question about style when converting from K&R to ANSI C. |
| |
> Thanks for the input. You've convinced me. When going through > arch/ppc/xmon/xmon.c, I will leave things like the following unchanged: > > /* Command interpreting routine */ > static int > cmds(struct pt_regs *excp) > {
Great.
> My changes will be similar to the following: > > @@ -1837,9 +1818,7 @@ > return *lineptr++; > } > > -void > -take_input(str) > -char *str; > +void take_input(char *str) > { > lineptr = str; > }
OK, I'm confused. You said you were convinced but then shouldn't that be
void take_input(char *str) { lineptr = str; }
?? -- --- Larry McVoy lm at bitmover.com http://www.bitmover.com/lm - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |