lkml.org 
[lkml]   [2003]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Question about style when converting from K&R to ANSI C.
From
Date
On Sun, 2003-06-01 at 10:52, Larry McVoy wrote:
> > Thanks for the input. You've convinced me. When going through
> > arch/ppc/xmon/xmon.c, I will leave things like the following unchanged:
> >
> > /* Command interpreting routine */
> > static int
> > cmds(struct pt_regs *excp)
> > {
>
> Great.
>
> > My changes will be similar to the following:
> >
> > @@ -1837,9 +1818,7 @@
> > return *lineptr++;
> > }
> >
> > -void
> > -take_input(str)
> > -char *str;
> > +void take_input(char *str)
> > {
> > lineptr = str;
> > }
>
> OK, I'm confused. You said you were convinced but then shouldn't that be
>
> void
> take_input(char *str)
> {
> lineptr = str;
> }
>
> ??
Yeah, I realized the inconsistency of that after sending. This is with
that change backed out (same as your example above):

@@ -1838,8 +1819,7 @@
}
void
-take_input(str)
-char *str;
+take_input(char *str)
{
lineptr = str;
}

My guiding principle in all this is "first, do no harm". That's why I
posted my question in the first place. Thanks for the help.

Steven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [from the cache]
©2003-2011 Jasper Spaans