Messages in this thread |  | | | Date | Fri, 9 May 2003 17:11:34 -0700 | | From | Greg KH <> | | Subject | Re: [RFC][PATCH] Dynamic PCI Device IDs |
| |
On Tue, May 06, 2003 at 11:35:17AM -0500, Matt Domsch wrote: > > You can't just call driver_attach(), as the bus semaphore needs to be > > locked before doing so. In short, you almost need to duplicate > > bus_add_driver(), but not quite :) > > Right, and it seems to work. I made driver_attach non-static, declared > it extern in pci.h, and call it in pci-driver.c while holding the bus > semaphore and references to the driver and the bus. This also let me > delete my probe_each_pci_dev() function and let the driver core > handle it.
Nice, this looks much better. I don't have a problem with this patch anymore. I'll wait for Pat to ack the driver core changes to see if he agrees with them before sending this on.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |