Messages in this thread | | | Date | Thu, 8 May 2003 17:10:42 +0200 | From | Ingo Oeser <> | Subject | Re: top stack (l)users for 2.5.69 |
| |
On Wed, May 07, 2003 at 01:38:56PM -0700, Randy Dunlap wrote: > I've written a few of the stack reduction patches. Lots of ioctl functions > need work, so gcc handling it better would be good to have. > > I have mostly used kmalloc/kfree, but using automatic variables is certainly > cleaner to write (code). One of the patches that I did just made each ioctl > cmd call a separate function, and then each separate function was able to use > automatic variables on the stack instead of kmalloc/kfree. I prefer this > method when it's feasible (and until gcc can handle these cases).
Wouldn't be a explicit union a better solution for the switch-statement-issue?
That way you still can use stack, are using even less of it and have still all cases in place.
Regards
Ingo Oeser -- Marketing ist die Kunst, Leuten Sachen zu verkaufen, die sie nicht brauchen, mit Geld, was sie nicht haben, um Leute zu beeindrucken, die sie nicht moegen. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |