Messages in this thread | | | Date | Wed, 7 May 2003 11:50:38 +0100 | From | viro@parcelfa ... | Subject | Re: [PATCH] Process Attribute API for Security Modules 2.5.69 |
| |
On Tue, May 06, 2003 at 12:13:25PM -0400, Stephen Smalley wrote: > +static int proc_attr_readdir(struct file * filp, > + void * dirent, filldir_t filldir)
Umm... How about having it merged with proc_base_readdir()? I.e. have both call the common helper. Ditto for lookups.
Other than that (and missing check for copy_to_user() return value in ->read()) I don't see any problems here. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |