[lkml]   [2003]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH] Dynamic PCI Device IDs
    > I like this patch a _lot_ better, nice job.


    > Only one comment:
    > > + if (error < 0)
    > > + return error;
    > > + return count;
    > > +
    > > +
    > > + return count;
    > > +}
    > Oops, lost the tabs at the end of the function :)

    Duh. Good eyes. Fixed.

    > This function will not link up a device to a driver properly within
    > the driver core, only with the pci code. So if you do this, the
    > driver core still thinks you have a device that is unbound, right?
    > Also, the symlinks don't get created from the bus to the device I
    > think, correct?

    I think you're right.

    > Unfortunatly, looking at the driver core real quickly, I don't see a
    > simple way to kick the probe cycle off again for all pci devices, but
    > I'm probably just missing something somewhere...

    I think drivers/base/bus.c: driver_attach() is what we want, which will
    walk the list of the bus's devices and run bus_match() which is
    pci_bus_match() which will scan for us. Just need to un-static
    driver_attach() I expect. Pat, does this sound right?

    If that works, probe_each_pci_dev() can go away. I'll play with it some

    Matt Domsch
    Sr. Software Engineer, Lead Engineer, Architect
    Dell Linux Solutions
    Linux on Dell mailing lists @

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:35    [W:0.022 / U:40.864 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site