lkml.org 
[lkml]   [2003]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4)
On Sun, 4 May 2003, Chuck Ebbert wrote:

>
> > if(create_file_name (slot_cur, buf)==0)
>
> Wow. Three whitespace violations on one line:
>
> - no space after 'if'
> - space between function and args
> - no space around '==' operator
>
> I know you didn't write that, I just had to comment because it almost
> hurts to look at it...
>
> >- snprintf (slot_cur->hotplug_slot->name, 30, "%s", );
> >+ snprintf (slot_cur->hotplug_slot->name, 30, "%s" );
>
>
> Doesn't this need a fourth parameter here instead of just
> removing the comma?

Yes, Andreas Haumer fixed the compile problems correctly in his post.

Geller Sandor <wildy@petra.hos.u-szeged.hu>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.033 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site