Messages in this thread Patch in this message | | | Date | Sun, 4 May 2003 02:28:40 -0700 | From | William Lee Irwin III <> | Subject | Re: statistics for this mailinglist |
| |
On Sun, 4 May 2003 00:43:05 -0700, William Lee Irwin III wrote: >>> You still haven't fixed the bug in your script. Please post the >>> script so it can be fixed.
On Sun, May 04, 2003 at 11:06:39AM +0200, J?rn Engel wrote: >> Google is your friend: >> http://www.vanheusden.com/mboxstats/ >> But I wonder if you really want to fix a text munching program written >> in c++. What an interesting choice.
On Sun, May 04, 2003 at 02:10:24AM -0700, William Lee Irwin III wrote: > I don't. I do, however, have a vested interest in getting the affected > stats accurately reported again.
The "isemail" parameter to array::addstring() calls out to get_email_address() to get the string, which breaks the string on any ' ' character (though, oddly, not other kinds of whitespace), while hunting for a run of consecutive characters between '<' and '>'.
Otherwise, a non-blank-breaking convention that performs its work on the raw string passed to it is used.
i.e. the error is a one-liner where the get_email_address() convention is incorrectly specified by passing a 0 instead of a 1 as the second argument of array::addstring() when the header matches "Organization:".
-- wli
--- main.cpp.orig 2003-05-04 02:22:49.000000000 -0700 +++ main.cpp 2003-05-04 02:23:02.000000000 -0700 @@ -459,7 +459,7 @@ } else if (strncmp(msg[loop], "Organization: ", 14) == 0) { - org.addstring(&msg[loop][14], 1); + org.addstring(&msg[loop][14], 0); } else if (strncmp(msg[loop], "User-Agent: ", 12) == 0) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |