lkml.org 
[lkml]   [2003]   [May]   [31]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 31 May 2003 15:37:54 -0400
FromChris Heath <>
SubjectRe: [PATCH][2.5] UTF-8 support in console
Here's the patch again, with suggested changes.


> +	if (!p) return;> > Please split this into two lines. Can p ever be null_

p could never be null, as it turns out. So I removed this line. :-)


> +		q = p->inverse_trans_unicode = (u16 *) > +			kmalloc(MAX_GLYPH * sizeof(u16), GFP_KERNEL);> > The cast is not needed.  And btw, where is q freed?

It is freed. Grep for kfree.*inverse_trans_unicode.

Chris
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2005-03-22 13:35    [from the cache]
©2003-2008