lkml.org 
[lkml]   [2003]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] sx tty_driver add .owner field remove MOD_INC_DEC_USE_COUNT
    Date
    In message <12430000.1054244110@w-hlinder> you write:
    > --On Thursday, May 29, 2003 12:02:50 PM -0700 Greg KH <greg@kroah.com> wrote:
    >
    > >
    > > Ick, this patch should be reverted, it should not be removing
    > > sx_hungup() for no reason. I think Hanna agrees with this.
    >
    > Yup. Sorry. Not sure what happened there. Here is the patch
    > to replace the sx_hangup function. This is based off 2.5.70-bk3
    > and I have compiled it but dont have the hardware to test it.

    Yes, but I don't think you need to put back the comment about
    decrementing use counts 8)

    > +/* I haven't the foggiest why the decrement use count has to happen
    > + here. The whole linux serial drivers stuff needs to be redesigned.
    > + My guess is that this is a hack to minimize the impact of a bug
    > + elsewhere. Thinking about it some more. (try it sometime) Try
    > + running minicom on a serial port that is driven by a modularized
    > + driver. Have the modem hangup. Then remove the driver module. Then
    > + exit minicom. I expect an "oops". -- REW */

    Cheers,
    Rusty.
    --
    Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:35    [W:0.037 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site