Messages in this thread | | | Date | Thu, 29 May 2003 03:01:16 -0700 (PDT) | Subject | Re: must-fix list, v5 | From | "David S. Miller" <> |
| |
From: Andi Kleen <ak@suse.de> Date: Thu, 29 May 2003 11:46:48 +0200
I believe the remaining limits are harmless, but of course it's cleaner to not have them.
The ethtool one was the worst. It's why I didn't copy your code :-)
If you use the function that extensively it would be better to allow it to nest (e.g. add a field for the current offset in task struct). Otherwise someone will get it wrong sooner or later. (like the sock/tw_bucket ;)
This is why I kept it private to the compat layer, I see no reason to let it slip into other code at all.
Ok thanks. I will port it to my 2.4 code.
Did you test them all?
I tested most of them, but very lightly. I didn't test the SG_IO stuff but that barely worked even beforehand :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |