Messages in this thread | | | Date | Thu, 29 May 2003 14:06:22 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH][ATM] assorted he driver cleanup |
| |
Em Thu, May 29, 2003 at 12:31:17PM -0400, chas williams escreveu: > In message <20030529162125.GU24054@conectiva.com.br>,Arnaldo Carvalho de Melo w > rites: > >> @@ -189,7 +187,7 @@ > >> #define HE_SPIN_LOCK(dev, flags) spin_lock_irqsave(&(dev)->global_lock, > >flags) > >> #define HE_SPIN_UNLOCK(dev, flags) spin_unlock_irqrestore(&(dev)->global_l > >ock, flags) > > > >Is the above really needed? > > well, according to the programmer's guide:
no, no, I was talking just about the need for HE_SPIN_LOCK wrapper, not the locking, i.e. couldn't it be just:
spin_lock_irqsave(&dev->global_lock, flags)
used so that it is clear that it is a irqsave variation, etc?
- Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |