Messages in this thread | | | Date | Mon, 26 May 2003 16:12:34 +1000 (EST) | From | James Morris <> | Subject | Re: [PATCH] make icmp.c be more verbose on broadcast icmp errors |
| |
On Fri, 23 May 2003, Maciej Soltysiak wrote:
> if (net_ratelimit()) > printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP " > + "type %u, code %u " > "error to a broadcast.\n", > - NIPQUAD(skb->nh.iph->saddr)); > + NIPQUAD(skb->nh.iph->saddr), > + icmph->type, icmph->code);
> if (net_ratelimit()) > - printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP error to a broadcast.\n", > - NIPQUAD(skb->nh.iph->saddr)); > + printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP type %u, code %u error to a broadcast.\n", > + NIPQUAD(skb->nh.iph->saddr), > + icmph->type, icmph->code);
Perhaps make this a static inline, icmp_warn_invalid() or similar.
- James -- James Morris <jmorris@intercode.com.au>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |