Messages in this thread Patch in this message | | | Date | Thu, 22 May 2003 20:15:14 +0200 | From | Manuel Estrada Sainz <> | Subject | Re: [PATCH] Re: request_firmware() hotplug interface, third round and a halve |
| |
On Thu, May 22, 2003 at 06:57:30PM +0100, Simon Kelley wrote: > Works great for me now. > > It's noisy: I'd remove/disable the printks in firmware_data_read and > firmware_data_write > before it goes in.
I'd rather not resend it all again.
Attached goes an incremental patch just in case, but I don't mind resending it later, once the bulk of it goes in.
Have a nice day
Manuel
-- --- Manuel Estrada Sainz <ranty@debian.org> <ranty@bigfoot.com> <ranty@users.sourceforge.net> ------------------------ <manuel.estrada@hispalinux.es> ------------------- Let us have the serenity to accept the things we cannot change, courage to change the things we can, and wisdom to know the difference. --- drivers/base/firmware_class.c 2003/05/22 14:49:44 1.14 +++ drivers/base/firmware_class.c 2003/05/22 18:07:38 @@ -152,8 +152,6 @@ struct firmware_priv *fw_priv = class_get_devdata(class_dev); struct firmware *fw = fw_priv->fw; - printk("%s: count:%d offset:%lld\n", __FUNCTION__, count, offset); - if (offset > fw->size) return 0; if (offset + count > fw->size) @@ -204,12 +202,9 @@ struct firmware *fw = fw_priv->fw; int retval; - printk("%s: count:%d offset:%lld\n", __FUNCTION__, count, offset); retval = fw_realloc_buffer(fw_priv, offset + count); - if (retval) { - printk("%s: retval:%d\n", __FUNCTION__, retval); + if (retval) return retval; - } memcpy(fw->data + offset, buffer, count); | |