lkml.org 
[lkml]   [2003]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Ext2-devel] [RFC] probably bug in current ext3/jbd
    From
    Date
    Hi,

    On Tue, 2003-05-20 at 01:46, Alex Tomas wrote:

    > please, look:
    >
    > thread A commit thread
    >
    > if (jh->b_committed_data) {
    > kfree(jh->b_committed_data);
    > jh->b_committed_data = NULL;
    > }
    > access for
    > b_committed_data == NULL ?

    Not with BKL. Without it, yes, that's definitely a risk, and you need
    some locking for the access to b_committed_data. Without that, even if
    you keep the jh->b_committed_data field valid, you risk freeing the old
    copy that another thread is using.

    Cheers,
    Stephen

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:35    [W:0.019 / U:31.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site