lkml.org 
[lkml]   [2003]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subjecttry_then_request_module
    Date
    > ChangeSet 2003/05/17 12:39:18-07:00, torvalds @ home.transmeta.com [diffview]
    >
    > Make request_module() take a printf-like vararg argument instead of a string.
    >
    > This is what a lot of the callers really wanted.

    Excellent! I'll close my older version of the same thing.

    If someone is feeling eager, many callers could change to
    try_then_request_module(), eg:

    diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.5.69-bk13/drivers/net/ppp_generic.c working-2.5.69-bk13-try/drivers/net/ppp_generic.c
    --- linux-2.5.69-bk13/drivers/net/ppp_generic.c 2003-05-19 10:53:44.000000000 +1000
    +++ working-2.5.69-bk13-try/drivers/net/ppp_generic.c 2003-05-19 11:38:40.000000000 +1000
    @@ -1959,13 +1959,8 @@ ppp_set_compress(struct ppp *ppp, unsign
    || ccp_option[1] < 2 || ccp_option[1] > data.length)
    goto out;

    - cp = find_compressor(ccp_option[0]);
    -#ifdef CONFIG_KMOD
    - if (cp == 0) {
    - request_module("ppp-compress-%d", ccp_option[0]);
    - cp = find_compressor(ccp_option[0]);
    - }
    -#endif /* CONFIG_KMOD */
    + cp = try_then_request_module(find_compressor(ccp_option[0]),
    + "ppp-compress-%d", ccp_option[0]);
    if (cp == 0)
    goto out;

    Thanks!
    Rusty.
    --
    Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:35    [W:0.028 / U:123.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site