lkml.org 
[lkml]   [2003]   [May]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 15 May 2003 02:37:17 -0400
FromJeff Garzik <>
SubjectRe: [PATCH] iphase fix.
Linux Kernel Mailing List wrote:
> ChangeSet 1.1127, 2003/05/14 20:44:02-07:00, davej@codemonkey.org.uk
> > 	[PATCH] iphase fix.
> 
> 	This went into 2.4 nearly a year back with the wonderfully
> 	descriptive  "Fix from maintainer" comment.

> diff -Nru a/drivers/net/fc/iph5526.c b/drivers/net/fc/iph5526.c
> --- a/drivers/net/fc/iph5526.c	Wed May 14 21:17:37 2003
> +++ b/drivers/net/fc/iph5526.c	Wed May 14 21:17:37 2003
> @@ -2984,8 +2984,7 @@>  	 */
>  	if ((type == ETH_P_ARP) || (status == 0))
>  		dev_kfree_skb(skb);
> -	else
> -		netif_wake_queue(dev);
> +	netif_wake_queue(dev);
>  	LEAVE("iph5526_send_packet");


This appears to revert a fix.

You only want to wake the queue if you have room to queue another skb.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [from the cache]
©2003-2008