Messages in this thread | | | Date | Wed, 14 May 2003 13:36:45 -0700 (PDT) | Subject | Re: [PATCH][ATM] add reference counting to atm_dev | From | "David S. Miller" <> |
| |
From: chas williams <chas@cmf.nrl.navy.mil> Date: Wed, 14 May 2003 16:20:09 -0400
this patch adds a reference count to atm_dev, and a lock to protect the members of struct atm_dev. atm_dev_lock is now used to protect the atm_dev linked list.
Nice. You may wish to try and make it so that atm_dev_lock can be privatized to one file, using callbacks or something similar, so that the device list implementation isn't exported all over the place.
- fops_get (dev->ops); + try_module_get(dev->ops->owner);
Use __module_get() in this kind of situation.
Fix this up and resend, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |