lkml.org 
[lkml]   [2003]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ioctl32: kill code duplication (sparc64 tester wanted)
Hi!

> > > I don't have a sparc64, but there's certainly no <asm/mtrr.h> for
> > > > that arch..
> >
> > I thought I killed that one?
>
> The patch you attached added it..

There are probably more such mistake. It should be easy for anyone
with sparc64 to kill them all at once.

> > > Also #including c files is ugly as hell. What's the #ifdef INCLUDES
> > > supposed to help?
> >
> > Yes, but do you have better proposal how to kill 4000+ lines of code
> > from each 64-bit architecture?
>
> What's the reason you can't build fs/compat_ioctl.c normally and pull
> in the arch magic through a magic asm/ header?

Some architectures need special stuff (mtrr's), so I'd have to include
.c files, too (the other way). [Look at how the table of ioctls is
generated, its asm magic].

> You still haven't answered
> the second question, btw..

Are you asking why are there #includes in compat_ioctl.c? Its because
there is so many of them, and having to update all archs when you
tuoch fs/compat_ioctl.c would be bad.

Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.051 / U:5.188 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site