lkml.org 
[lkml]   [2003]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] fix net/rxrpc/proc.c
From
In article <20030512190036.B20068@figure1.int.wirex.com> (at Mon, 12 May 2003 19:00:36 -0700), Chris Wright <chris@wirex.com> says:

> * David S. Miller (davem@redhat.com) wrote:
> > On Mon, 2003-05-12 at 17:38, Chris Wright wrote:
> > > A recent change in 2.5.69-bk from Yoshfuji broke compilation of rxrpc
> > > code. It erroneously adds an owner field to the rxrpc_proc_peers_ops
> > > seq_operations. Fix below.
> >
> > Why is it "erroneous"? Just add the proper linux/module.h include
> > to net/rxrpc/proc.c instead of spewing baseless claims.
>
> Sorry, if I'm missing the obvious, but looking at my current bk tree I
> see this:
>
> include/linux/seq_file.h
>
> struct seq_operations {
> void * (*start) (struct seq_file *m, loff_t *pos);
> void (*stop) (struct seq_file *m, void *v);
> void * (*next) (struct seq_file *m, void *v, loff_t *pos);
> int (*show) (struct seq_file *m, void *v);
> };
>
> It looks to me like there is a simple mistake of seq_operations !=
> file_operations when adding .owner = THIS_MODULE to the file_operations.

Sorry, it's my mistake. David, please apply his patch.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site