Messages in this thread | | | Date | Sat, 10 May 2003 12:54:43 +0200 | From | Francois Romieu <> | Subject | Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!) |
| |
chas williams <chas@locutus.cmf.nrl.navy.mil> : [...] > i hope you dont mind, but i really dislike the goto. one is plenty.
I am not fond of the 'test before destruction' approach when the tests could have been avoided. Anyway you maintain the driver on a regular basis, you are free to choose the fix.
> attached is a cleanup for the iphase (i made a small addition -- i believe > the MEMDUMP_XXXXXXREG cases are also guilty of dereferencing).
Yes.
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |