lkml.org 
[lkml]   [2003]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!)
chas williams <chas@locutus.cmf.nrl.navy.mil> :
[...]
> i hope you dont mind, but i really dislike the goto. one is plenty.

I am not fond of the 'test before destruction' approach when the tests
could have been avoided. Anyway you maintain the driver on a regular basis,
you are free to choose the fix.

> attached is a cleanup for the iphase (i made a small addition -- i believe
> the MEMDUMP_XXXXXXREG cases are also guilty of dereferencing).

Yes.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.118 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site