Messages in this thread | | | Date | Wed, 30 Apr 2003 21:12:58 -0700 (PDT) | Subject | Re: [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68 | From | "Randy.Dunlap" <> |
| |
> On Tue, Apr 29, 2003 at 04:11:28PM -0700, Randy.Dunlap wrote: >> On Tue, 29 Apr 2003 23:08:30 +0000 Gabriel Devenyi <devenyga@mcmaster.ca> >> wrote: >> >> | Thanks for the suggestions, I'm kinda new at this and just following the >> TODO | which unfortuately says "sed s/return EWHATEVER/return >> -EWHATEVER/". I'll | work on checking the things you suggested. As for >> your other questions, the | kernel did build but I didn't attempt to boot >> it, I'll be sure to do so in | the future. Thanks for the encouragement. >> | >> | P.S. Anyone who works on KernelJanitor, kj.pl is suggesting some of the >> things | I'm changing which aparently I shouldn't. >> >> >> The kernel-janitor TODO should be your guide. However, it needs some >> updating too, so the best thing to do is ask about things on >> kernel-janitor-discuss@lists.sf.net before you spend time on them. >> >> [item updates are welcome] > > Well... Turn that one into > * try and convince XFS folks that they want to use negative numbers > for error values (will be tricky - they really don't like to diverge from > IRIX codebase) > * ditto for JFS - again, a bunch of functions use positive error > values. > * oprofile init on alpha should be returning negative in case of > failure to follow the common conventions. > > AFAICS that's it.
OK, did that. and thanks.
The updated KJ TODO will be available shortly.
~Randy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |