lkml.org 
[lkml]   [2003]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remove kdevname() before someone starts using it again
On Sun, Apr 06, 2003 at 04:28:38PM -0400, Nicholas Wourms wrote:
> Christoph Hellwig wrote:
> > --- 1.14/fs/libfs.c Wed Jan 1 02:18:35 2003
> > +++ edited/fs/libfs.c Wed Mar 26 21:32:02 2003
> > @@ -332,14 +332,3 @@
> > set_page_dirty(page);
> > return 0;
>
> A quick grep shows that Intermezzo FS still uses kdevname if
> you've turned on debugging (fs/intermezzo/sysctl.c).

Look at the code. It's not compiled in, and if someone sets the
cpp macro it won't build for lots of other reasons (e.g. set_device_ro
prototype).

> As for
> pending stuff, both Reiser4 & pktcdvd also use it. So I
> guess people are still using it...

That's they problem. Bot that either of them is scheduled for 2.6
anyway as far as I know.

> What is your reason for
> removing it?

It's a broken interface. Use the proper replacements instead.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.139 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site