![]() | |||||||||||||
Messages in this thread |
On Fri, Apr 04 2003, Jörn Engel wrote: > > + error = copy_to_user(io, my_io, sizeof(*my_io)) ? -EFAULT : 0; > > copy_to_user returns the bytes successfully copied. > error is set to -EFAULT, if there was actually data transferred? > > How about: > + error = copy_to_user(io, my_io, sizeof(*my_io)) < sizeof(*my_io) ? -EFAULT : 0; Pure nonsense! Correct logic, and much nicer to read IMO is: if (copy_to_user(io, my_io, sizeof(*my_io)) error = -EFAULT; -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 12:34 [W:0.280 / U:0.070 seconds] ©2003-2008 Jasper Spaans | |||||||||||||