lkml.org 
[lkml]   [2003]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix NULL handler for compat_ioctl
Ben Collins <bcollins@debian.org> wrote:
>
> > - sys_ioctl takes three args, but this vector is going to be called with
> > four. That's making assumptions about arg passing conventions which may
> > not be true.
> >
> > - sys_ioctl() is asmlinkage, but the caller of this vector doesn't know
> > that. Arguments may get put in the wrong place.
>
> Out of all the register_ioctl32_conversion functions that were
> consolidated with this patch, only s390 and x86_64 did not already use
> this same convention. linux/ioctl32.h already documents (and has always
> been that way) this feature.

Yup. I'm not surprised that it works. But ick.

> Maybe you feel better about this patch instead?

Infinitely ;)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.044 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site