lkml.org 
[lkml]   [2003]   [Apr]   [3]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
SubjectRe: [patch] add i2c_clients_command()
FromGerd Knorr <>
Date03 Apr 2003 10:49:53 +0200
Christoph Hellwig <hch@infradead.org> writes:

> > +void i2c_clients_command(struct i2c_adapter *adap, unsigned int cmd, void *arg)
> > +{
> > +	int i;
> > +
> > +	down(&adap->list);
> > +	for (i = 0; i < I2C_CLIENT_MAX; i++) {
> > +		if (NULL == adap->clients[i])
> > +			continue;

> This is a horrible algorithm!  Please introduce a per-adapter client
> lists.

Well, I can't easily fix that single function.  The whole i2c core
manages the clients that way, i.e. the whole i2c subsystem would need
a rewrite ...

  Gerd

-- 
Michael Moore for president!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:34    [W:0.482 / U:0.250 seconds]
©2003-2008 Jasper Spaans