lkml.org 
[lkml]   [2003]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Update to orinoco driver (2.4)
    On Sat, Apr 26, 2003 at 06:22:40AM +0100, Christoph Hellwig wrote:
    > On Sat, Apr 26, 2003 at 10:30:18AM +1000, David Gibson wrote:
    > > On Fri, Apr 25, 2003 at 03:37:06PM +0100, Christoph Hellwig wrote:
    > > > > +static void __exit exit_hermes(void)
    > > > > +{
    > > > > +}
    > > > > +
    > > > > module_init(init_hermes);
    > > > > +module_exit(exit_hermes);
    > > >
    > > > Please don't add exmpty functions without a reak good reason.
    > >
    > > And the real good reason would be that the module can't be unloaded
    > > without an exit function.
    >
    > That braindamage fortunately is not true for 2.4 and still needs
    > fixing for 2.5.

    Removing one empty function is insufficient cause for me to maintain
    separate 2.4 and 2.5 versions. When and if this changes in 2.5, I'll
    remove the function.

    --
    David Gibson | For every complex problem there is a
    david@gibson.dropbear.id.au | solution which is simple, neat and
    | wrong.
    http://www.ozlabs.org/people/dgibson
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:35    [W:0.019 / U:33.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site