lkml.org 
[lkml]   [2003]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.4-rc1] fix side effects of the kmod/ptrace secfix
On Fri, 25 Apr 2003, Andreas Gietl wrote:
>
> it shows:
> PID TTY STAT TIME COMMAND
> 2092 ttyp0 S 0:00 su guest -c ps $PPID;wc -m </proc/$PPID/cmdline
> 0

Ah ok, I tested this with LC_CTYPE=de_DE.UTF-8, in this case wc has
to read the contents of the file. When a single-byte locale is used,
wc just does fstat64() to get the file size(which returns 0 for the file).

> but cat shows:
> su guest -c 'ps $PPID; cat /proc/$PPID/cmdline'
> PID TTY STAT TIME COMMAND
> 2144 ttyp0 S 0:00 su guest -c ps $PPID; cat /proc/$PPID/cmdline
> suguest-cps $PPID; cat /proc/$PPID/cmdline
>
> what happened?

This is ok, access_proces_vm() is working.

> > [pid 2599] --- SIGSTOP (Stopped (signal)) @ 0 (0) ---
> > [pid 2599] write(1, "\n", 1
>
> it shows:
> localhost root # strace -fewrite su -c /bin/echo 2>&1 | grep pid
> [pid 2159] write(1, "\n", 1

Looks ok also, the task->mm->dumpable check is removed from prace_check_attach

> Looks like my results are slightly diffent, Does this mean i did not apply the
> patch correctly? I applied it twice manually, because patch did not succeed

The above shows that at least the two-liner task_dumpable diff is applied.
> and compiled the kernel 3 times...

Sorry for the different output, I should have made my tests safer against
system variants. It should have applied clean, maybe some white space issue
or so, I'll check it. shutdown didn't change? What does it on your system?

Bernd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.480 / U:0.416 seconds]
©2003-2014 Jasper Spaans. Advertise on this site