lkml.org 
[lkml]   [2003]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.67-ac2 direct-IO for IDE taskfile ioctl (0/4)
On Thu, Apr 24 2003, Bartlomiej Zolnierkiewicz wrote:
> > If all the rework against bio_map_user() and friends is needed for other
> > reasons then fine. But it doesn't seem to be needed for the IDE taskfile
> > ioctl.
>
> Rework of bio_map_user() and co. is minimal and not needed but otherwise
> I will have to duplicate same code in 4 places. bio_map_user() now does
> allocated bio checking and grabs extra reference to bio which all users of
> old bio_map_user() have to do anyway (and they will probably forgot to).

The bio_map_user() changes look perfectly fine, I'd like to commit those
separately.

From the performance point of view, I agree that the whole thing is
rather silly (I mean, who cares?). But the non-allocating nature of
HDIO_DRIVE_TASK is a step in the right direction.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.085 / U:0.528 seconds]
©2003-2014 Jasper Spaans. Advertise on this site