Messages in this thread Patch in this message | | | Date | Wed, 2 Apr 2003 12:11:57 +0200 | From | Jörn Engel <> | Subject | Re: [PATCH] PATCH: dpt_i2o memory leak comments |
| |
On Tue, 1 April 2003 13:15:04 +0000, Randy.Dunlap wrote: > > | @@ -1318,7 +1318,9 @@ > | while(*status == 0){ > | if(time_after(jiffies,timeout)){ > | printk(KERN_WARNING"%s: IOP Reset Timeout\n",pHba->name); > | - kfree(status); > | + /* We loose 4 bytes of "status" here, but we cannot > | + free these because controller may awake and corrupt > | + those bytes at any time */ > s/loose/lose/ > > | @@ -1336,6 +1338,9 @@ > | } > | if(time_after(jiffies,timeout)){ > | printk(KERN_ERR "%s:Timeout waiting for IOP Reset.\n",pHba->name); > | + /* We loose 4 bytes of "status" here, but we cannot > | + free these because controller may awake and corrupt > | + those bytes at any time */ > s/loose/lose/
It might also be nice to point out, that we lose the 4 bytes once per *boot*, not continuously. Some people like me have a much easier time to accept the loss then. :)
Jörn
-- It's just what we asked for, but not what we want! -- anonymous - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |