Messages in this thread |  | | | From | Andries.Brouwer@cwi ... | | Date | Sun, 20 Apr 2003 00:18:36 +0200 (MEST) | | Subject | Re: Private namespaces |
| |
> How does this look?
Ach - just a moment ago I submitted only that single improvement, but you do the whole list.
(It is OK, of course. I looked for a second and concluded that in all other cases the return value was in fact -ENOMEM, so that no change was required. Only in the case of security_task_alloc() is a different value, -EPERM, likely.)
Concerning style - I don't like
if ((retval = copy_sighand(clone_flags, p))) very much.
Where there is an if() one expects a boolean condition, and in superficial reading one can easily mistake = for ==, in spite of the additional parentheses. Just
retval = copy_sighand(clone_flags, p); if (retval) is so much clearer.
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |