Messages in this thread | | | Date | Fri, 18 Apr 2003 14:44:25 -0400 | From | Jeff Garzik <> | Subject | Re: [TRIVIAL] kstrdup |
| |
Linus Torvalds wrote: > On Fri, 18 Apr 2003, Jeff Garzik wrote: > >>Linus Torvalds wrote: >> >>>On Fri, 18 Apr 2003, Jeff Garzik wrote: >>> >>> >>>>You should save the strlen result to a temp var, and then s/strcpy/memcpy/ >>> >>>No, you should just not do this. I don't see the point. >> >>strcpy has a test for each byte of its contents, and memcpy doesn't. >>Why search 's' for NULL twice? > > > No, my point is that kstrdup() _itself_ just shouldn't be done. I don't
Ah, indeed :)
> see it as being worthy of kernel support. Most of the kernel string data > structures are NOT random zero-ended strings anyway: they are either > strictly limited in some ways ("ends in '\0', but limited to PATH_MAX), or > they are explicitly sized ("struct qstr").
Quite true
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |