lkml.org 
[lkml]   [2003]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: BUGed to death
    On Tue, Apr 15, 2003 at 10:30:24AM -0400, rwhron@earthlink.net wrote:
    > The patch below eliminates 4 BUG() calls that clearly
    > cannot happen based on the context.

    This looks bogus.

    > --- linux-2.5.67-mm2/fs/reiserfs/hashes.c.orig 2003-04-15 10:11:44.000000000 -0400
    > +++ linux-2.5.67-mm2/fs/reiserfs/hashes.c 2003-04-15 10:13:43.000000000 -0400
    > @@ -90,10 +90,6 @@
    >
    > if (len >= 12)
    > {
    > - //assert(len < 16);
    > - if (len >= 16)
    > - BUG();
    > -

    Imagine I pass in 20. Previously, the BUG triggers. Not any more.
    Ditto the other changes. Or am _I_ missing something ?

    Dave

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:34    [W:0.022 / U:89.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site