lkml.org 
[lkml]   [2003]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PC-9800 subarch. support for 2.5.64-ac3 (11/20) NIC
Osamu Tomita wrote:
>
> This is the patch to support NEC PC-9800 subarchitecture
> against 2.5.64-ac3. (11/20)
>
> C-bus(PC98's legacy bus like ISA) network cards support.
> Change IO port and IRQ assign.
> Add auto detect function for some cards.
> PCI netwwork card works fine without patch.

I had a quick look at the ne.c part of this patch, and I can't
say I'm really thrilled to see some 30 or more ifdefs added to
just one driver. Okay, I know it is an old crusty ISA driver, but
when somebody has to go in there to repair the inevitable bitrot,
the readability factor is significantly reduced.

If the hardware differences can't be abstracted out any cleaner
than this, then it probably makes sense to just make a ne2k-pc98.c
and you can scrap all the bits you don't want. Code sharing is
fine, but no point bending over backwards in trying to do so.
(e.g. we already have MCA and PCMCIA versions of ne.c now...)

Thanks,
Paul.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [from the cache]
©2003-2011 Jasper Spaans