Messages in this thread Patch in this message | | | Date | Mon, 31 Mar 2003 16:42:15 +0200 | From | Stelian Pop <> | Subject | Re: [patch] fix ec_read using wrong #define's in sonypi driver. |
| |
On Mon, Mar 31, 2003 at 01:30:45PM +0000, Daniel K. wrote:
> This patch will make the driver use the correct #define's when > querying battery charge. > > This error sneaked into 2.4.20-pre1, > and have been present in 2.5 since 2.5.49.
Damn, a copy and paste error and nobody noticed until now.
Thanks Daniel!
Linus, Marcelo, please apply it.
Stelian.
--- linux-2.4.21-pre6.vanilla/drivers/char/sonypi.c 2003-03-29 17:27:22.000000000 +0000 +++ linux-2.4.21-pre6/drivers/char/sonypi.c 2003-03-30 11:44:42.000000000 +0000 @@ -531,7 +531,7 @@ ret = -EFAULT; break; case SONYPI_IOCGBAT1REM: - if (ec_read16(SONYPI_BAT1_FULL, &val16)) { + if (ec_read16(SONYPI_BAT1_LEFT, &val16)) { ret = -EIO; break; } @@ -539,7 +539,7 @@ ret = -EFAULT; break; case SONYPI_IOCGBAT2CAP: - if (ec_read16(SONYPI_BAT1_FULL, &val16)) { + if (ec_read16(SONYPI_BAT2_FULL, &val16)) { ret = -EIO; break; } @@ -547,7 +547,7 @@ ret = -EFAULT; break; case SONYPI_IOCGBAT2REM: - if (ec_read16(SONYPI_BAT1_FULL, &val16)) { + if (ec_read16(SONYPI_BAT2_LEFT, &val16)) { ret = -EIO; break; }
-- Stelian Pop <stelian@popies.net> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |